Skip to content

Conversation

@francescoalemanno
Copy link
Contributor

@francescoalemanno francescoalemanno commented Jun 18, 2020

Adding Factored to base package

@francescoalemanno francescoalemanno requested a review from jbrea June 18, 2020 15:54
@jbrea
Copy link
Collaborator

jbrea commented Jun 18, 2020

After efords comment JuliaApproxInference/LikelihoodfreeInference.jl#5 I thought it may be a good idea to move the priors to Distributions.jl. There is also this discussion in discourse. What do you think?

@francescoalemanno
Copy link
Contributor Author

francescoalemanno commented Jun 18, 2020

It is a very good idea, but i think that it will seriously hinder the speed at which we can create a workable solution.
For example Distributions.jl already has a factored distribution (it is called Product), but it doesnt support mixing continuous and discrete distributions, and ofcourse since Product is based on arrays, it is not possible to extend it and have it type stable at the same time. Thus i know for sure that Distributions is not going to accept a PR with Factored inside

@francescoalemanno
Copy link
Contributor Author

i will merge this, just to start working on it, we can excise this code anytime ;)

@francescoalemanno francescoalemanno merged commit 05d9e67 into master Jun 18, 2020
@francescoalemanno francescoalemanno deleted the factored_distribution branch June 18, 2020 23:34
@jbrea
Copy link
Collaborator

jbrea commented Jun 21, 2020

Yes. This makes total sense. We can put whatever we want here for now and move it to other packages anytime later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants